fix: Exit code not properly returned when using steps
bvoq opened this issue · comments
Is there an existing issue for this?
- I have searched the existing issues.
Version
6.1.0
Description
Adding the following step will lead to a zero exit code, even when the test is supposed to fail.
scripts:
test:
steps:
- melos exec -f --dir-exists=test -- flutter test
If you run melos test
I would expect a non-zero exit code, however I get exit code 0.
However, if you run melos exec -f --dir-exists=test -- flutter test
directly, you will get exit code 1.
Steps to reproduce
Add any failing test to your project.
Then add the above script to melos.yaml
.
Then run melos test
which should throw a non-zero exit code.
Expected behavior
I would expect a non-zero exit code but I get a zero exit code.
Screenshots
No response
Additional context and comments
This was tested on macOS but I don't think it's platform specific.
This is a duplicate of #527
Which you also commented on...
This is a duplicate of #527 Which you also commented on...
Ok thanks, I wasn't sure if I needed to file a new issue.
Thanks for maintaining this cool tool :-)
Ah, this is actually not a duplicate, I'm re-opening this one.
@jessicatarra could you maybe have a look at this one? :)