Support symlinks in the jd-cli wrapper

Question

Support symlinks in the jd-cli wrapper

cutephoton opened this issue 6 years ago · comments

Consider modifying the startup script (jd-cli) to use this instead:

DIR=$( dirname $( readlink -f ${BASH_SOURCE[0]} ))

Because it works with symlinks.

oxr463 · Answer 1 · Sun May 17 2020 05:37:47 GMT+0800 (China Standard Time)

~~Where does that script come from anyway? I don't see it in the repository.~~

Found it, https://github.com/kwart/jd-cmd/blob/master/jd-cli/src/main/bin/jd-cli

oxr463 · Answer 2 · Sun May 17 2020 05:53:29 GMT+0800 (China Standard Time)

Consider modifying the startup script (jd-cli) to use this instead:
DIR=$( dirname $( readlink -f ${BASH_SOURCE[0]} ))
Because it works with symlinks.

This is not POSIX-compliant, (See: https://stackoverflow.com/a/29835459/8507637).

cutephoton · Answer 3 · Sun May 17 2020 09:31:45 GMT+0800 (China Standard Time)

POSIX can be really limiting, eh? sigh I think readlink -e path might be a compromise since it's generally available. It's not shell specific. Do you see a better option?