internetarchive / openlibrary

One webpage for every book ever published!

Home Page:https://openlibrary.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Author name resolution unit tests should be case sensitive

scottbarnes opened this issue · comments

Problem

Related: #9390, #9003, internetarchive/infogami#221

Evidence / Screenshot

internetarchive/infogami#221 will cause Infogami's ~ behavior go back to doing a LIKE operation, and this will cause Infogami's ~ behavior to go out of sync with the mock_infobase behavior added in #9003, which made ~ case insensitive. mock_infobase and the unit tests will need to be updated to be case sensitive.

Once/if #9390 is implemented, these test will need to be made case insensitive again, but until that happens, they should be case sensitive.

See #9003 for the exact files to update to make the name resolution tests case sensitive once more.

Relevant URL(s)

Reproducing the bug

No response

Context

No response

Notes from this Issue's Lead

Proposal & constraints

Related files

Stakeholders

Note: Before making a new branch or updating an existing one, please ensure your branch is up to date.

I changed this to Priority 3 on the theory that mock_infobase() was doing inaccurate LIKE queries for years and nobody seemed to notice. That said, this would be a small/quick PR for whoever wishes to do it.