internetarchive / openlibrary

One webpage for every book ever published!

Home Page:https://openlibrary.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

CSS for new "My Books" page list showcase affecting list droppers in search results

jimchamp opened this issue · comments

Problem

The class my-lists is used both in the lists section of "My Books" droppers and the new list showcase in the "My Books" page. The CSS rules added for my-lists in #8878 are affecting the styling of "My Books" droppers in search results.

Evidence / Screenshot

image

Relevant URL(s)

You can see this on any author page.

Reproducing the bug

While logged in:

  1. Go to an author page.
  2. Expand any "My Books" dropper
  • Expected behavior: Lists are listed in a column.
  • Actual behavior: Lists are listed in a row.

Context

  • Browser (Chrome, Safari, Firefox, etc): Any
  • OS (Windows, Mac, etc):All
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Notes from this Issue's Lead

Proposal & constraints

The my-lists class name needs to be updated to something else in one of the components (either the dropper or the new "My Books" page showcase).

Related files

Stakeholders

@benbdeitch

Note: Before making a new branch or updating an existing one, please ensure your branch is up to date.