Remove legacy ASN.1 definitions
kincaidoneil opened this issue · comments
I noticed the link in the Interledger v4 RFC links to an "InterledgerPacket" ASN.1 file, which defines older types of packets. I think these files should be removed for clarity:
asn1/InterledgerPacket.asnasn1/InterledgerPaymentRequest.asnasn1/InterledgerQuotingProtocol.asnasn1/LegacyInterledgerProtocol.asnasn1/PreSharedKeyV2.asn
Can these be safely deleted (and there'll still be in the commit history for future reference)?
I think everything in that list can be deleted except InterledgerPacket.asn. That still defines the Packet, PacketSet and InterledgerPacket for the current ILPv4 packet types (12, 13, and 14).
I think we could probably get rid of this Liquidity Curve section, though.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat.
@kincaidoneil are you going to make the changes suggested above, or should we close this one?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat.
@kincaidoneil are you going to make the changes suggested above, or should we close this one?
@sappenin At last... here's that PR!