Update IL-RFC-30 discussion of timestamps and GeneralizedTime wrt ILP and BTP
sappenin opened this issue · comments
This ASN.1 definition for BTP specifies GeneralizedTime as the type for Error.triggeredAt and Prepare.expiresAt.
However, per this comment from @adrianhopebailie, no ASN.1 definitions should reference GeneralizedTime, but should instead use InterledgerTimestamps (see spec here).
Actually BTP does use Generalized Time rather than Interledger timestamps: https://github.com/interledgerjs/btp-packet/blob/master/index.js#L26-L27
Ah, yes, you're right.
So, it seems like Interledger packets use Interledger timestamps but BTP is using the special variant of GeneralizedTime (per your link above).
So, I suppose IL-RFC-30 is incorrect, then? Those rules only apply to BTP, but not to ILP packets?
So, I suppose IL-RFC-30 is incorrect, then?
Yes. It needs to be updated.
However, per this comment from @adrianhopebailie, no ASN.1 definitions should reference GeneralizedTime, but should instead use InterledgerTimestamps
Sorry, I meant for ILP. The rationale for the switch was fixed size which is probably less relevant for BTP
Makes sense - so I think the ASN definition is correct, but IL-RFC-30 needs to be cleaned up. Should I create a separate ticket and close this one?
Let's just track it here for context.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat.
Bumping to keep this open a bit longer...
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat.