Giters

intel / pcm

Intel® Performance Counter Monitor (Intel® PCM)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

CMake options prefix

artiomn opened this issue · comments

commented

Probably is not a bad idea to add prefix to the options. I.e. INTEL_PCM_.

After this, the options will be named not like NO_ASAN, but like INTEL_PCM_NO_ASAN.

Why:

  • Visually "highlight" PCM options.
  • Remove potential intersection with other projects. I.e., somebody using add_subdirectory and has an option with a name similar to PCM. He doesn't want to affect the PCM option, but he does and needs to make workarounds.
  • Remove potential intersection with special CMake variables.

How:

  • Add new options with prefixes.
  • Add stub for old option names, which will print deprecation warning.
  • Remove old names in some future version.

P.S.: Probably CMake option command will be more natural and convenient to use than "ordinary variables".