[Firefox] Navigation > Comments page is slow to load
addyosmani opened this issue · comments
I haven't been able to repro this in other browsers, but in Firefox (desktop) the top-level Comments page takes a long time to return any data. It works fine with all our other views.
Video: http://recordit.co/uKni7RWp9n
Versions tested: FF 46, 47, 50
Oddly, it works absolutely fine in Firefox for Android (stable).
Similarly odd, testing locally, we have no issues loading this page as quickly as any other in FF50:
Paging @wanderview in case he has more information available that would help with repros.
Here's Firefox 47 for me using the deployed version:
Thanks @insin! I wonder if this issue is resolved for @wanderview now too. Might have been temporary.
/newcomments is sensitive to whatever's happening right now on HN, as on initial load it'll keep showing a spinner until somebody creates/updates a comment and its id appears on https://hacker-news.firebaseio.com/v0/updates, then it'll be live from that point onwards in the current session.
Just reading the component/UpdateStore code makes me want to rewrite it 🐱
The top level comments do work for me with default settings. Its only when I check "offline mode" do they stop working. This happens for me across all platform and browser configurations.
Devtools shows this in the console:
HNServiceRest.js:37 Uncaught (in promise) TypeError: l(...).once is not a function(…)
@wanderview I can repro this in offline mode now in both FF and Chrome. Marking as a bug and will look into a patch.
I have a patch locally that I believe fixes this. Deployed to https://react-hn-comments.appspot.com. @wanderview would you mind testing that with Offline Mode enabled please? 🍬
Works great. Thanks!
🎉 🎈 🚢 Yay!
Thanks for confirming. I'll get the patch landed soon.