Giters

input-output-hk / hydra

Implementation of the Hydra Head protocol

Home Page:https://hydra.family/head-protocol/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove hardcoded protocol parameters file from demo

abailly-iohk opened this issue · comments

commented

Why

We provide a default protocol-parameters.json file in the hydra-cluster/config directory that's used by the demo's hydra-nodes. The format of this file evolves over time as the PParams data structure from the ledger changes, and while there's a backward compatible serialisation mechanism that prevents the hydra-node from rejecting the file, this leads to confusing behaviour as reported in #1117.

What

PR #1122 proposes to update this file which is a fine stop-gap solution but in the long run does not help much as this issue will certainly happen again. While it would be possible to put a test in place that checks the checked-in file is correct w.r.t. to our current ledger, it seems simpler to do what's suggested in the tutorial and pull the parameters from the underlying cardano-node, modifying some values to ensure 0 fees in the Head.