Return HTTP codes (follow recommendation)
FabioPinheiro opened this issue · comments
At the moment, when using did come over HTTPS, the return code of HTTP POST is 200.
The recommendation from the didcomm-messaging specs is 202 Accepted.
A successful message receipt MUST return a code in the 2xx HTTPS Status Code range. 202 Accepted is recommended.
The goal is to follow the recommendation.
There are also some points in favor of using 204 No Content. (Might be worth debating here)
Internal this Jira ticket is known as ATL-6041.
@antonbaliasnikov can you also add a check on the mediator-test-suite for this?
https://github.com/input-output-hk/didcomm-v2-mediator-test-suite/
Although this 202 is just a recommendation from DID Comm specs. So I was thinking about duplicating trust ping as a new test and checking the return code.
I'm going to leave this ticket open in the meantime.
The test suite was updated in input-output-hk/didcomm-v2-mediator-test-suite#8