Unable to connect to HTTPS server with API package
limzykenneth opened this issue · comments
Describe the bug
With the latest version of nexrender-api, it is not possible to connect to a server behind HTTPS in node.js. This is because the current implementation through node-fetch enforces the use of a http agent where for HTTPS links a https agent is required. Also left a comment in the relevant commit: b862cf6
I understand the fix is to avoid using the new native fetch available in newer version of node.js implemented via Undici but I don't understand the reason behind wanting to avoid that. I can help create a fix for this but I need to know why native node.js Undici fetch is avoided as it is my preferred solution.
Information about environment
- Which version of nexrender are you using? 1.45.0
- What kind of the setup do you have? server+worker
- Are you using pre-built binaries or globally installed npm packages? npm packages
- Which kind (and version) of operating system you are running it in? Windows
- Any additional information that might be helpful
Expected behavior
Connection to both HTTP and HTTPS should both work
Good point, will push a fix for this soon
Published a fix for this in 1.45.1
https://github.com/inlife/nexrender/releases/tag/v1.45.1
Great, thanks! I'll have a test later today or this week.
It is working now