Giters

inlets / inletsctl

Create inlets servers on the top cloud platforms

Home Page:https://docs.inlets.dev/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Download command failed on MacOS

alexellis opened this issue · comments

commented

Expected Behaviour

inletsctl download --pro should get me a MacOS binary when using Mac, but it was a Linux binary that was downloaded

Possible Solution

Add unit tests and fix bug.

Steps to Reproduce (for bugs)

  1. Use a Mac
  2. Run inletsctl download --pro
  3. See the wrong binary, it downloads for Linux

cc @Waterdrips

commented

@Waterdrips perhaps you can write a Go unit test that runs the command then checks the binary is as expected? I used the file utility to find the binary format was correct.

file /usr/local/bin/inlets-pro 
/usr/local/bin/inlets-pro: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, stripped

There may be other ways to do this too.