imguiWrapperTypes.h should use "uintptr_t" instead of "void*"
mdempsky opened this issue · comments
In Go 1.14, the Go compiler added a "checkptr" feature that detects misuse of unsafe.Pointer. It's triggering within imgui-go because of conversions like here:
Line 24 in d81fabb
The problem is IggTextureID is declared in imguiWrapperTypes.h as typedef void *IggTextureID. This makes cgo use unsafe.Pointer when representing this type in Go.
If you instead #include <stdint.h> and use typedef uintptr_t IggTextureID, the error should go away.
Thank you for raising this.
I have changed the type for IggTextureID to uintptr_t . For the others this should not be necessary, as they do hold actual pointer to the types.
I'm still trying to reproduce the warning on my side, can you confirm in parallel that this fixes your issue?
This fixes the immediate issue I was having. However, a similar error remains. Building imgui-go-examples/cmd/example_sdl_opengl3 with go run -race -tags 'sdl' . (after bumping go.mod to latest version):
fatal error: checkptr: unsafe pointer arithmetic
goroutine 1 [running, locked to thread]:
runtime.throw(0x6fd0fd, 0x23)
/home/steve/Go/go-current/src/runtime/panic.go:1114 +0x72 fp=0xc00006da68 sp=0xc00006da38 pc=0x4b8f22
runtime.checkptrArithmetic(0x8, 0x0, 0x0, 0x0)
/home/steve/Go/go-current/src/runtime/checkptr.go:26 +0xce fp=0xc00006da98 sp=0xc00006da68 pc=0x48ebae
github.com/inkyblackness/imgui-go-examples/internal/renderers.(*OpenGL3).Render(0xc000100050, 0x4434000044a00000, 0x4434000044a00000, 0x268b380)
/home/steve/Go/steve/imgui-go-examples/internal/renderers/OpenGL3.go:144 +0x112d fp=0xc00006dce0 sp=0xc00006da98 pc=0x5bafcd
github.com/inkyblackness/imgui-go-examples/internal/demo.Run(0x721e00, 0xc000114210, 0x7206e0, 0xc000100050)
/home/steve/Go/steve/imgui-go-examples/internal/demo/Run.go:117 +0x2ba fp=0xc00006ddf8 sp=0xc00006dce0 pc=0x57da8a
main.main()
/home/steve/Go/steve/imgui-go-examples/cmd/example_sdl_opengl3/main.go:35 +0x2d8 fp=0xc00006df88 sp=0xc00006ddf8 pc=0x5bdcb8
runtime.main()
/home/steve/Go/go-current/src/runtime/proc.go:203 +0x212 fp=0xc00006dfe0 sp=0xc00006df88 pc=0x4bb5a2
runtime.goexit()
/home/steve/Go/go-current/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc00006dfe8 sp=0xc00006dfe0 pc=0x4e7681
exit status 2
OK, thank you for the reproduction steps. I'll have a look.
go vet should be able to report suspicious uintptr-to-unsafe.Pointer conversions as well.
Welp, now we're at the next library :)
Because this now is an issue of go-gl/gl .
Since that is used via the examples, this issue here can be closed, and the new problem can be tracked via inkyblackness/imgui-go-examples#3 .
Thank you all for raising this - it helps making APIs cleaner.
Yup. I thought so too but I don't enough about this end of the language to be helpful. I see someone has raised the issue in go-gl already.
In case anyone is still watching this, imgui-go-examples has finally been modified to use checkptr safe functions from the newest go-gl/gl library. It can now be run with the detector active.
Excellent