Tree related helper function TreeNodeToLabelSpacing is missing

Question

Tree related helper function TreeNodeToLabelSpacing is missing

futjikato opened this issue 5 years ago · comments

Moritz Spindelhirn commented 5 years ago

Hi,

TreeAdvanceToLabelPos as well as GetTreeNodeToLabelSpacing are missing. This makes it a little harder to build nicely aligned tree menus. Is this a scope related choice not to expose these?

I am not a C/C++ dev myself and as such cant promise to make a pull request even if the addition is in scope. But I could give it a try.

Christian Haas · Answer 1 · Mon Sep 02 2019 03:11:06 GMT+0800 (China Standard Time)

Hello @futjikato , thank you for your message!
They are not intentionally hidden, just not yet required so far.
These are simple functions, you should be able to add them if you like - see for similar functions on how it is done.
For instance, TreeAdvanceToLabelPos() would be similar to TreePop(), so follow its wrapper implementation and essentially copy/paste :)
TreeNodeToLabelSpacing() isn't much different, only add a return value of float32 (and keep in mind, getter names don't have the prefix Get in go.
Take the documentation from imgui.h for the functions and you are good to go :)

Moritz Spindelhirn · Answer 2 · Mon Sep 02 2019 17:29:51 GMT+0800 (China Standard Time)

Thanks! Will try to make a PR later today

Moritz Spindelhirn · Answer 3 · Tue Sep 03 2019 00:41:58 GMT+0800 (China Standard Time)

As of Juli 2019 TreeAdvanceToLabelPos is deprecated so I will just add TreeNodeToLabelSpacing as that seems to be the replacement.
See: https://github.com/ocornut/imgui/blob/master/imgui.h#L1542

Moritz Spindelhirn · Answer 4 · Tue Sep 03 2019 01:29:12 GMT+0800 (China Standard Time)

See PR #46

Christian Haas · Answer 5 · Thu Sep 05 2019 20:24:49 GMT+0800 (China Standard Time)

Thank you for your contribution! I'll do a release with that soon, I first want to handle the other issue as well.