Giters

inkyblackness / imgui-go

Go wrapper library for "Dear ImGui" (https://github.com/ocornut/imgui)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add Image::AddImageQuad method

VityaSchel opened this issue · comments

commented

Add AddImageQuad method implemented in

imgui-go/imgui/imgui_draw.cpp

Line 1621 in 44567f2

void ImDrawList::AddImageQuad(ImTextureID user_texture_id, const ImVec2& p1, const ImVec2& p2, const ImVec2& p3, const ImVec2& p4, const ImVec2& uv1, const ImVec2& uv2, const ImVec2& uv3, const ImVec2& uv4, ImU32 col)

to Go wrapper

commented

I'm not much into Go and learning it for about a week, so please correct me, if I'm wrong, but it seems, to resolve this, we only need to make several small modifications to files:

  1. Add iggAddImageQuad method to wrapper/DrawList.cpp with call to
list->AddImageQuad(/*args*/)

  1. Export it in wrapper/DrawList.h

  2. Expose it in DrawList.go for imgui-go users by adding AddImageQuad func

Then, ask giu contributors to wrap it once more within giu. Or use imgui-go drawlist directly with giu helper.

commented

Hi there, and thank you for the proposal. The proposed path sounds right and it would be a good first issue to try out locally as well!

commented

Hi there, and thank you for the proposal. The proposed path sounds right and it would be a good first issue to try out locally as well!

@dertseha I made a pull request (#185). Please tell me you can accept it! I tried my best to follow code style

commented

Done via #185 and #190 .
Thank you!