[Parameterize variables] Fix this issue in several-many templates
samhld opened this issue · comments
A lot of templates currently don't parameterize things that should be parameterized. This includes input URLs, output URLs, bucket names, org names, etc.
For templates to be useful for others, these things need to be parameterized.
TO DO:
Go through all templates and find where change is needed.
Hi @samhld can you share an example?
@xe-nvdk here's an example. This is likely a URL that should be parametrized so that people without that specific URL can work with this template immediately: https://github.com/influxdata/community-templates/blob/master/aws_cloudwatch/aws_cloudwatch.yml#L688
More specifically, it should probably be urls = ["$INFLUX_URL"]
Oh. I understand what you mean now. Yes, agree, that's a very recommended use of variables. I will review "my" and other templates in case I miss something and keep hardcoded something.