inetaf / netaddr

Network address types

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

fuzz build broken

josharian opened this issue · comments

#204 says it fixes the fuzz build by removing a duplicate type detection. But on my machine, #204 breaks the fuzz build. As main at f6a6f43, I see:

$ go-fuzz-build
/Users/josh/x/netaddr/fuzz.go:133:40: undeclared name: appendMarshaler
/Users/josh/x/netaddr/fuzz.go:187:18: undeclared name: appendMarshaler
typechecking of . failed

@dsnet any idea why we're seeing opposite failures?

Using different people's go-fuzz impls? Dmitry's vs Katie et al's?

Oh, I tried it with the dev.fuzz branch (i.e., Katie's).

I didn't realize it was Dmitry's fuzzer implementation. We should probably revert my change.

OR if we think Katie's is the future, we can roll-forward to use that.

Let's support both for the moment; it's easy. I'll send a PR.