remove IPPort.WithIP, IPPort.WithPort?

[Josh Bleecher Snyder]

These were useful as shims while updating Tailscale to use the opaque IPPort. They're a bit ugly, though. Should we remove them prior to upstreaming?

[Jimmy Zelinskie]

Did you just replace those calls with netaddr.IPPortFrom()?

[Josh Bleecher Snyder]

Did you just replace those calls with netaddr.IPPortFrom()?

I haven't done it yet. The fix would be a combination of two things. In some places, explicitly tracking an IP and a port. In others, replacing with IPPortFrom.

[Josh Bleecher Snyder]

Upstreaming of IPPort (as AddrPort) is complete; these got cut.