IPSet mysteriously does nothing on invalid inputs

Question

IPSet mysteriously does nothing on invalid inputs

danderson opened this issue 3 years ago · comments

If I AddRange an invalid range, IPSet does nothing, successfully. This is surprising, a more normal idiom in Go would be to have AddRange return an error, and have a MustAddRange that panics if you really want a shorthand.

It does make the builder more annoying to wield, since a bunch of common adders/removers can now fail, but that feels better to me than silently doing something surprising.

Josh Bleecher Snyder · Answer 1 · Sat May 22 2021 00:59:15 GMT+0800 (China Standard Time)

Both this (return an error instead of swallowing invalid input to IPSetBuilder) and the direction in #167 (fix an invalid input to IPPrefixFrom rather than return an error) feel locally reasonable, but they conflict philosophically. I'm not sure what the resolution is, but I'm not very comfortable about it.

Josh Bleecher Snyder · Answer 2 · Sat May 22 2021 01:00:16 GMT+0800 (China Standard Time)

Oh, and I see this is also now being discussed in #178. :)

Brad Fitzpatrick · Answer 3 · Sat May 22 2021 01:32:30 GMT+0800 (China Standard Time)

I replied on #178 then.

Dave Anderson · Answer 4 · Sat May 22 2021 04:31:47 GMT+0800 (China Standard Time)

Yeah, the resolution of this will be subsumed by what we decide our global behavior should be.