Custom Component Errors/Warnings
prescottprue opened this issue · comments
When trying to use a custom component, one can trying passing a string or a whole component.
String
Does not seem to be a common pattern for passing a component
<Notifs CustomComponent={Snackbar} />
Problems
- Does not allow props to be passed
- Passes all props (warning will throw for unnecessary props):
Full Component
Seems to the common method of accepting a component as a prop used in Libraries like material-ui
like here. That way props can be passed and set within the component (like you are doing with key).
<Notifs CustomComponent={<Snackbar open message="some" />} />
Problems
- Throws invalid element type warning:
- Even after changing src to allow this, the
addComponentAsRefTo
is still thrown (might be due to npm-linking causing react version conflicts):
Thanks for this report! I'll look into reproducing this. I know the CustomComponent
API could be beefed up, it was created for a small handful of usecases and the ones you've outlined seem likely.
If I have time I'll take a stab at a PR, but would love help from others!