release_id

Question

release_id

randallsquared opened this issue 7 years ago · comments

Is there a reason release_id is snake_case, and everything else camelCase? If not, let's change it.

Irakli Nadareishvili · Answer 1 · Sat Jan 20 2018 14:55:48 GMT+0800 (China Standard Time)

Good catch, thank you! It should indeed be consistent.

One last sanity check before we make the final change - should everything be snake-case or camelCase? Not sure if there's a more commonly adopted pattern in JSON?

I generally don't like cased anything because I personally feel it is more error-prone that snake-cased (and harder to read) but that's just me.

Are we set on camel-case?

Randall Randall · Answer 2 · Sat Jan 20 2018 22:52:26 GMT+0800 (China Standard Time)

I'm not set on anything, and don't think it matters overmuch; the important thing is that its decided and final.

Irakli Nadareishvili · Answer 3 · Sat Jan 20 2018 23:29:26 GMT+0800 (China Standard Time)

LOL! That comment seemed very set on being non-committal :)

Randall Randall · Answer 4 · Sat Jan 20 2018 23:34:58 GMT+0800 (China Standard Time)

We as a community have argued about this for decades. Nobody has convincingly won. Therefore it’s a bad idea to spend rfchealthcheck time on the argument. Pick one to standardize on, and we can ignore the whole thing for this RFC indefinitely. :)

Irakli Nadareishvili · Answer 5 · Sat Jan 20 2018 23:41:01 GMT+0800 (China Standard Time)

OK, CamelCases win.

Irakli Nadareishvili · Answer 6 · Mon Jan 22 2018 06:58:07 GMT+0800 (China Standard Time)

I believe this is now fixed with the latest merge