missing MODULE_LICENSE

Question

wongsyrone opened this issue 9 years ago · comments

WARNING: modpost: missing MODULE_LICENSE() in drivers/net/imq.o

Gao Feng · Answer 1 · Sun Jun 28 2015 21:45:12 GMT+0800 (China Standard Time)

Which file or patch?

Syrone Wong · Answer 2 · Sun Jun 28 2015 21:52:32 GMT+0800 (China Standard Time)

I think it should be drivers/net/imq.c in https://github.com/imq/linuximq/blob/master/latest/linux-3.18-imq.diff. can you check all patches related to drivers/net/imq.c?

Gao Feng · Answer 3 · Sun Jun 28 2015 22:01:54 GMT+0800 (China Standard Time)

There is one line "MODULE_LICENSE("GPL");" in linux-3.18-imq.diff.

Syrone Wong · Answer 4 · Sun Jun 28 2015 22:03:00 GMT+0800 (China Standard Time)

but it is in file net/netfilter/xt_IMQ.c

Gao Feng · Answer 5 · Mon Jun 29 2015 08:10:53 GMT+0800 (China Standard Time)

Ok. I get it. Thanks.

I have fixed it.

Syrone Wong · Answer 6 · Mon Jun 29 2015 16:46:22 GMT+0800 (China Standard Time)

@gfreewind sorry to bother you, but I want to ask why there's no MODULE_ALIAS_RTNL_LINK("imq") in linux-3.18-imq.diff.

Gao Feng · Answer 7 · Mon Jun 29 2015 16:57:01 GMT+0800 (China Standard Time)

Thanks your finding.
I think it is lost by chance. I have fixed it now.

Syrone Wong · Answer 8 · Mon Jun 29 2015 17:00:50 GMT+0800 (China Standard Time)

@gfreewind the line you added has two plus sign(++) at the front of line.

Gao Feng · Answer 9 · Mon Jun 29 2015 18:12:21 GMT+0800 (China Standard Time)

thanks again :(
It is the my fault. I am busy today, so that I have not tested it.