Ignore routes without an id

[dnlup]

Ignore routes without an id

[Antonio Musolino]

What happens if I don't pass an ID, but I use inside the route sendGaugeMetric, do we need to metric it or not? I think in this case, we can don't decorate the request/reply with the methods.

[dnlup]

🤔 that's a good point. I think maybe we could either:

• handle this internally using the same strategy:
  • use an util function to check if the route should be skipped and use it manually in each method that send a metric
  • centralise this check somehow, maybe with a proxy approach or something that allows us to call those methods with the check baked in
• decorate req and reply with a boolean that says if the route should be ignored and let the user handle it

I need to think about it a little more, do you have something else in mind?

[Antonio Musolino]

The problem is that the label function, in this case, has no id. Then if I allow using the function, I will enable the user to send a metric without an ID. From my view we have these possibilities:

• Make sendMetrics nope functions, but I don't like it.
• do sendMetrics throw
  WDYT?

Another point is that because we make ID required, can we evaluate the possibility of making it more visible?

[dnlup]

The problem is that the label function, in this case, has no id.

🤔 The label function should be able to access the routeId from <request|reply>.context.config.metrics.routeId or options.config.metrics.routeId. Does that solves the problem for you?

sendMetrics should not throw, it would be against the concept of ignoring a route.

[dnlup]

Another point is that because we make ID required, can we evaluate the possibility of making it more visible?

What do you mean by "more visible"?

[Simone Corsi]

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀