immobiliare / dats

📈 Minimalistic zero-dependencies statsd client for Node.js

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Call onError when there is a metric with a float number

antoniomuso opened this issue · comments

We don't check that the metrics should be an integer; we can do it by calling onError if not integer.

I won't use onError becuase it an user definable callback, we don't know how they are handled externally, we may cause problems!

I think a simple warn in console should be good, it's the end user who must then handle the parsing!

But in general, you have to handle it; if you don't do that, it's your problem. WDYT?

But I'm not sure this has to be threated as an Error, statsd as a Proxy support floating point, it could be the pluggable storage that we use that doesn't support it or either a misconfiguration of Grafana

As discussed, we can use debug to alert the user in not production environment.