imbrn / v8n

☑️ JavaScript fluent validation library

Home Page:https://imbrn.github.io/v8n

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Logo has bad contrast on GitHub in dark mode

sbarfurth opened this issue · comments

The logo displayed at the top of the readme has bad contrast when dark mode is active on GitHub. Perhapt a slightly lighter grey could be used for the font. Here is a screenshot of this issue:

Screenshot 2022-02-17 at 17 10 51

It may be more welcoming for new consumers if the logo was a little better to read. Obviously a different shade of gray would not work on all backgrounds. For a more universal solution it might be an interesting thought to have the text colored green like the logo or some other, less common color.

I'm no designer, I just thought this may be worth keeping track of.

This is even worse on mobile:

image

commented

Hello @barfurth
Would it be okay to design some logos and upload them?

Hey @Seung-hwan285! I'm gonna pass this question to @imbrn who can give you a definitive answer.

Hello @Seung-hwan285 and @barfurth.

@Seung-hwan285 thank you very much for your interest in contributing. You're really welcome to do that.
You can open a pull request replacing the current logo with your suggestion.

commented

Hello @imbrn Thank you so much.

Closed via #226 - thank you @Seung-hwan285