Flash on off not working.

Question

Flash on off not working.

pgorasva opened this issue 6 years ago · comments

pgorasva commented 6 years ago

Ricardo Torrão · Answer 1 · Tue Jun 19 2018 19:18:04 GMT+0800 (China Standard Time)

@pgorasva

can you please provide more info and steps to reproduce? Namely:

are you using the example app?
which version of CameraManager are you using?
which iPhone model and iOS version are you using?

Thanks

pgorasva · Answer 2 · Wed Jun 20 2018 14:22:08 GMT+0800 (China Standard Time)

@torrao
No i am not using example app.
i am using 4.1 camera manager version
iPhone model : iPhone SE
iOS version: 11

Ricardo Torrão · Answer 3 · Wed Jun 20 2018 17:30:04 GMT+0800 (China Standard Time)

@pgorasva

can you please try the example app in that same phone to see if the flash works?

pgorasva · Answer 4 · Wed Jun 20 2018 20:03:03 GMT+0800 (China Standard Time)

@torrao

i tried example app.
but flash working only in photo capture.when i try to record video flash was not working.

xC0der · Answer 5 · Wed Jun 20 2018 22:07:36 GMT+0800 (China Standard Time)

I'd bet it because it changed to torch for video in a prior iOS update. I'll have a look at the code and see what I can find @torrao

Ricardo Torrão · Answer 6 · Wed Jun 20 2018 23:30:57 GMT+0800 (China Standard Time)

@pgorasva @xC0der

I've made a PR #153 for fixing this and releasing it the next hour or so.

Basically I'm setting AVCaptureDevice.flashMode when CameraOutputMode.stillImage and AVCaptureDevice.torchMode otherwise (CameraOutputMode.videoWithMic or CameraOutputMode.videoOnly)

xC0der · Answer 7 · Thu Jun 21 2018 01:12:21 GMT+0800 (China Standard Time)

That should do it! Super fast turn around, nice work.

pgorasva · Answer 8 · Thu Jun 21 2018 13:14:39 GMT+0800 (China Standard Time)

it's working.

Thanks @torrao @xC0der