iluwatar / java-design-patterns-web

Java Design Patterns website at https://java-design-patterns.com

Home Page:https://java-design-patterns.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Some patterns show up more than once

JackieNim opened this issue · comments

Some patterns show up more than once, an example of this is the adapter and singleton pattern

image

Not smart enough to fix it but looking in /pages/pattern line 11 site.pages probably has a duplicate. Not sure where this is being populated.

I have a potential fix, don't have permissions to push to a branch to make PR

Hi @JackieNim, thanks for notifying about the issue. Please use the normal Github's forking workflow i.e. fork the main repository to your own account and make the pull request from there. See https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

By the way, there are other multiples also e.g. Singleton and Strategy. Not sure what's going on, maybe it's about localization...

@JackieNim detected another related problem, please see the description here #22