Recent merge commits cause compile errors
jwestbrook opened this issue · comments
Jason Westbrook commented
on the php7 branch during make
/usr/src/libxl/libxl-3.9.2.1/include_c/libxl.h:474:30: error: too many arguments to function 'xlSheetInsertRowA'
/usr/src/libxl/libxl-3.9.2.1/include_c/libxl.h:473:30: error: too many arguments to function 'xlSheetInsertColA'
/usr/src/libxl/libxl-3.9.2.1/include_c/libxl.h:476:30: error: too many arguments to function 'xlSheetRemoveRowA'
/usr/src/libxl/libxl-3.9.2.1/include_c/libxl.h:475:30: error: too many arguments to function 'xlSheetRemoveColA'
I updated to the latest libxl 3.9.4.3 as well and the same error was thrown during compile
Jan Ehrhardt commented
Could you try it with the php7_with_pulls branch of my fork:
git clone -b php7_with_pulls https://github.com/Jan-E/php_excel
Jason Westbrook commented
Yep your branch compiles cleanly with 3.9.2.1 and 3.9.4.3
Darren Odden commented
@Jan-E can you PR the php7_with_pulls