ikawaha / kagome

Self-contained Japanese Morphological Analyzer written in pure Go

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[homebrew] "bottle : unneeded is deprecated" warning

KEINOS opened this issue · comments

Not a bug of Kagome but a warning of brew because of goreleaser.

As of Kagome v2.7.0 + Homebrew 3.3.1 combination, a warning "Calling bottle :unneeded is deprecated" appears.

$ brew info kagome
Warning: Calling bottle :unneeded is deprecated! There is no replacement.
Please report this issue to the ikawaha/kagome tap (not Homebrew/brew or Homebrew/core):
  /usr/local/Homebrew/Library/Taps/ikawaha/homebrew-kagome/Formula/kagome.rb:9

ikawaha/kagome/kagome: stable 2.7.0
Self-contained Japanese Morphological Analyzer written in pure Go.
https://github.com/ikawaha/kagome
/usr/local/Cellar/kagome/2.7.0 (5 files, 61.5MB) *
  Built from source on 2021-09-17 at 09:10:04
From: https://github.com/ikawaha/homebrew-kagome/blob/HEAD/Formula/kagome.rb

$ brew doctor
Warning: Calling bottle :unneeded is deprecated! There is no replacement.
Please report this issue to the ikawaha/kagome tap (not Homebrew/brew or Homebrew/core):
  /usr/local/Homebrew/Library/Taps/ikawaha/homebrew-kagome/Formula/kagome.rb:9

Your system is ready to brew.

It seems to be related to the below issue of goreleaser. And fixed in goreleaser v0.183.0.

So, probably we have to just wait for a little to be reflected in goreleaser action.


Env info
$ brew --version
Homebrew 3.3.1
Homebrew/homebrew-core (git revision ec823dbf70f; last commit 2021-10-27)
Homebrew/homebrew-cask (git revision 876d3165c6; last commit 2021-10-27)

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.15.7
BuildVersion:	19H1519

Thanks for the detailed report ! I'll wait for golereaser-action to support it.

I confirm that the changes have been reflected in the latest "goreleaser-action" with the below workflow.

jobs:
  goreleaser:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v2
        with:
          fetch-depth: 0
      - name: Set up Go
        uses: actions/setup-go@v2
        with:
          go-version: '1.17.x'
      - name: Run GoReleaser
        uses: goreleaser/goreleaser-action@v2
        with:
          version: latest
          args: release --config .goreleaser.yml
        env:
          GITHUB_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}

So, I think this issue will be fixed in the next Kagome release.

$ brew info ikawaha/kagome/kagome
ikawaha/kagome/kagome: stable 2.8.0
Self-contained Japanese Morphological Analyzer written in pure Go.
https://github.com/ikawaha/kagome
/usr/local/Cellar/kagome/2.8.0 (5 files, 61.7MB) *
  Built from source on 2022-07-03 at 10:17:27
From: https://github.com/ikawaha/homebrew-kagome/blob/HEAD/Formula/kagome.rb

I also confirm that this issue has been resolved. Thank you!

Log
$ # Env info before install

$ date -R
Sun, 03 Jul 2022 10:45:20 +0900

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.15.7
BuildVersion:	19H1922

$ brew --version
Homebrew 3.5.2
Homebrew/homebrew-core (git revision 48dc582dfc9; last commit 2022-06-19)
Homebrew/homebrew-cask (git revision e83c83c0a2; last commit 2022-06-18)

$ # Not yet installed
$ brew list ikawaha/kagome/kagome
Error: No available formula or cask with the name "ikawaha/kagome/kagome".
Please tap it and then try again: brew tap ikawaha/kagome

$ brew doctor
Your system is ready to brew.
$ # Install
$ brew install ikawaha/kagome/kagome
==> Tapping ikawaha/kagome
Cloning into '/usr/local/Homebrew/Library/Taps/ikawaha/homebrew-kagome'...
***snip**

$ kagome version
2.8.0
   ipa v1.0.4
   uni v1.1.3

$ echo "すもももももももものうち" | kagome
すもも	名詞,一般,*,*,*,*,すもも,スモモ,スモモ
も	助詞,係助詞,*,*,*,*,も,モ,モ
もも	名詞,一般,*,*,*,*,もも,モモ,モモ
も	助詞,係助詞,*,*,*,*,も,モ,モ
もも	名詞,一般,*,*,*,*,もも,モモ,モモ
の	助詞,連体化,*,*,*,*,の,ノ,ノ
うち	名詞,非自立,副詞可能,*,*,*,うち,ウチ,ウチ
EOS

$ brew list ikawaha/kagome/kagome
/usr/local/Cellar/kagome/2.8.0/bin/kagome

$ brew doctor
Your system is ready to brew.

🎉

Thank you!!!