igrigorik / em-synchrony

Fiber aware EventMachine clients and convenience classes

Home Page:http://www.igvita.com/2010/03/22/untangling-evented-code-with-ruby-fibers

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Use of deprecated ::Fixnum in AR connection adapter

Gerard-at-Streamit opened this issue · comments

Since Ruby 2.4, Bignum and Fixnum have been unified into Integer (see Ruby 2.4. release). The use of Fixum generates a warning:

(....)/active_record/connection_adapters/em_mysql2_adapter.rb:27: warning: constant ::Fixnum is deprecated

Are there plans to update this?

Would you be willing to pull together a PR to address this? :-)

Sorry, took me some time to get back to this. Created a (very simple, but backwards compatible) PR.
Note that I did not touch the Fixnum used in the spec for TCPSocket. This appears to be the only other use of Fixnum (or Bignum) in this gem.