Single responsability

Question

Single responsability

JAIRMG opened this issue 4 years ago · comments

I think that saving the user data, for example the onBoardingData should be responsability of the ViewModel, what do you think?. Nice project btw!

Igor Kulman · Answer 1 · Mon Jun 29 2020 01:45:07 GMT+0800 (China Standard Time)

What do you mean by onboarding data? In the setup flow the ViewModel saves the RSS source the user selects: https://github.com/igorkulman/iOSSampleApp/blob/master/Sources/iOSSampleApp/Scenarios/Setup/ViewModels/SourceSelectionViewModel.swift#L80

Jair M Gaspar · Answer 2 · Mon Jun 29 2020 01:52:18 GMT+0800 (China Standard Time)

The OnBoardingCoordinator is saving the settings and the SetOptionsViewModel is practically empty, that's what I mean. This self.dataManager.set(key: SettingKey.onBoardingData, value: data) I think is a ViewModel responsability

Igor Kulman · Answer 3 · Mon Jun 29 2020 02:03:19 GMT+0800 (China Standard Time)

There is no OnBoardingCoordinator in this code base.