idlesign / torrentool

The tool to work with torrent files.

Home Page:https://github.com/idlesign/torrentool

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

IndexError: pop from empty list

oyjcmyn opened this issue · comments

Sometimes when parsing torrent files, an IndexError: pop from empty list error may occur. The torrent file appears to be fine since it can be opened and downloaded normally.
This torrent file cannot be parsed correctly:
88.torrent.zip

Thank you for the report.
We'll see what's the cause.

Okay, thank you very much.
If needed, I can provide more torrent files that cannot be parsed.

Can you please fix this bug so I can use torrentool? I really want to use it.

"Using bencodepy, the 88.torrent file can be parsed correctly. Should we consider replacing bencode with bencodepy?

This file contains garbage data errot: no is id.

Since this case is not covered by the bencode specification as far as I know, I see no reason to hide this fact (though we could have do so in potentia) and allow some arbitrary data as a hidden (and possibly malicious) payload.

Considered closed.
Feel free to reopen if required.