idaholab / malamute

Advanced manufacturing modeling and simulation

Home Page:https://mooseframework.inl.gov/malamute

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Removed unused params [!14 merged]

moosebuild opened this issue · comments

In GitLab by @socratesgorilla on Dec 1, 2022, 12:57

Merges unusedfix -> devel

Closes #36

CIVET encountered an error retrieving branch peatna/malamute:unusedfix.

This is typically caused by moosetest not having access to the repository.

Please grant Developer access to moosetest and try again.

In GitLab by @socratesgorilla on Dec 1, 2022, 12:59

added 1 commit

Compare with previous version

Job Documentation on 58fe0c8 wanted to post the following:

View the site here

This comment will be updated on new commits.

Job Coverage on 58fe0c8 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

CIVET Testing summary for 56a65a9

Precheck : Passed
Documentation : Passed
Mac Test : Passed
Test : Passed
Test Debug : Passed
Non unity build : Passed
Coverage : Passed

In GitLab by @cticenhour on Dec 1, 2022, 14:04

Commented on examples/sps/multiapp/diemodel/electrothermomechs/simple_geometries/yttria_electrothermomechanical_singleblock.i line 76

  [density_va] # initial condition set in ICs block below
  []
  [heat_transfer_radiation]
  []
  [current_density_J]
    family = NEDELEC_ONE
    order = FIRST
  []
[]

[ICs]
  [density_va_ic]
    type = FunctionIC
    variable = density_va
    function = '5010.0*(1-${initial_porosity})' # 3106.2 in kg/m^3
  []
[]

In GitLab by @cticenhour on Dec 1, 2022, 14:04

Commented on examples/sps/multiapp/diemodel/electrothermomechs/simple_geometries/yttria_electrothermomechanical_singleblock.i line 4


initial_porosity = 0.38
initial_temperature = 300 #roughly 600C where the pyrometer kicks in

In GitLab by @cticenhour on Dec 1, 2022, 14:04

This is my preferred fix for this instead of removing the parameter.

In GitLab by @socratesgorilla on Dec 1, 2022, 14:13

resolved all threads

In GitLab by @socratesgorilla on Dec 1, 2022, 14:13

resolved all threads

In GitLab by @socratesgorilla on Dec 1, 2022, 14:13

added 1 commit

  • 58fe0c8 - Fixed unused initial_porosity

Compare with previous version

In GitLab by @cticenhour on Dec 1, 2022, 14:15

approved this merge request

In GitLab by @cticenhour on Dec 1, 2022, 14:15

enabled an automatic merge when the pipeline for 58fe0c8 succeeds

CIVET Testing summary for 58fe0c8

Precheck : Passed
Documentation : Passed
Mac Test : Passed
Test : Passed
Test Debug : Passed
Non unity build : Passed
Coverage : Passed

In GitLab by @cticenhour on Dec 1, 2022, 14:44

mentioned in commit 102d244