Please distribute py.typed
srittau opened this issue · comments
I noticed that ics switched to hatchling two hours ago, so this could be actually be fixed. That said, while the repository includes a py.typed file, this isn't shipped with ics's 0.7.2 wheel file and thus not installed. With poetry this would be fixed by adding a include = ["*/py.typed"] line to the [tool.poetry] section. I'm not sure how hatchling handles this.
Looks good for 0.8
[finksim@escher ~]$ cd /tmp
[finksim@escher tmp]$ git clone git@github.com:ics-py/ics-py.git
Cloning into 'ics-py'...
remote: Enumerating objects: 4307, done.
remote: Counting objects: 100% (922/922), done.
remote: Compressing objects: 100% (352/352), done.
remote: Total 4307 (delta 525), reused 836 (delta 494), pack-reused 3385
Receiving objects: 100% (4307/4307), 1.86 MiB | 1.01 MiB/s, done.
Resolving deltas: 100% (2772/2772), done.
[finksim@escher tmp]$ cd ics-py/
[finksim@escher ics-py]$ python -m build
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (hatchling)
* Getting dependencies for sdist...
* Building sdist...
* Building wheel from sdist
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (hatchling)
* Getting dependencies for wheel...
* Building wheel...
Successfully built ics-0.8.0.dev0.tar.gz and ics-0.8.0.dev0-py3-none-any.whl
[finksim@escher ics-py]$ tar -tf ./dist/ics-0.8.0.dev0.tar.gz | grep typed
ics-0.8.0.dev0/src/ics/py.typed
[finksim@escher ics-py]$ zipinfo ./dist/ics-0.8.0.dev0-py3-none-any.whl | grep typed
-rw-r--r-- 2.0 unx 0 b- defN 20-Feb-02 00:00 ics/py.typed
If you want to make the effort to get 0.7 fixed, you can make a PR against the version-0.7 branch.