icetee / palladium

Send easily. Test for free. Send e-mail from Atom.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

<img /> received without src=""

meeshh opened this issue · comments

images are being received in the email without the src="" attribute. so no image is being loaded in the email.

Unfortunately, it's hard coded to take image from the "img" folder.

But it encodes into base64 and handles CID-it.

Would you test it?

so there is no way to do it without a base64 encoding? i have all my images hosted somewhere online

no, but I'll do it

Can you test the last commit? Only change the ~/.atom/packages/palladium/lib/components/mailer.js file and reset the Atom window.

i updated the package in atom, restarted and tested it but i still get the same result.

And add the new property to .mailconfig?

https://github.com/icetee/palladium/blame/c1fb29abab3f1932db49b6a19f363425c3fbf709/lib/settings/mailconfig.json

We are before publishing, we can only test it overwritten the file.

i added the new property and it didn't work.

Can you give me more information, maybe example?

I try image src with external URL and set disableImageEncode: true and works.

I published the v1.2.0 release.

ok it works now. the update notification wasn't pushed to atom so i went to the packages tab and updated from there.

thank you.
you can close this issue

If you have any ideas for developing a package, open a new issue.

Thanks