Time Zone support broken with TZInfo 2.0.0

Question

Time Zone support broken with TZInfo 2.0.0

ticky opened this issue 6 years ago · comments

TZInfo 2.0.0 was released in December, and icalendar’s monkey-patching doesn’t work due to some internal changes.

If a time zone has any timezone transitions, icalendar’s extensions break:

TZInfo::Timezone.get('Etc/UTC').ical_timezone(DateTime.now)
Traceback (most recent call last):
        8: from /app/bin/irb:18:in `<main>'
        7: from (irb):7
        6: from /app/vendor/bundle/ruby/2.5.0/gems/icalendar-2.5.2/lib/icalendar/tzinfo.rb:101:in `ical_timezone'
        5: from /app/vendor/bundle/ruby/2.5.0/gems/icalendar-2.5.2/lib/icalendar/tzinfo.rb:151:in `standard'
        4: from /app/vendor/bundle/ruby/2.5.0/gems/icalendar-2.5.2/lib/icalendar/tzinfo.rb:169:in `build_timezone'
        3: from /app/vendor/bundle/ruby/2.5.0/gems/icalendar-2.5.2/lib/icalendar/tzinfo.rb:169:in `tap'
        2: from /app/vendor/bundle/ruby/2.5.0/gems/icalendar-2.5.2/lib/icalendar/tzinfo.rb:173:in `block in build_timezone'
        1: from /app/vendor/bundle/ruby/2.5.0/gems/icalendar-2.5.2/lib/icalendar/tzinfo.rb:79:in `dtstart'
NameError (undefined local variable or method `local_start' for #<TZInfo::TimezoneTransition:0x00000000033b7290>
Did you mean?  local_start_at)

Misty De Méo · Answer 1 · Thu Jan 03 2019 14:04:59 GMT+0800 (China Standard Time)

Looks like that change is documented in version 2.0 of tzinfo's release notes:

The datetime, time, local_end, local_end_time, local_start and local_start_time instance methods of TZInfo::TimezoneTransition have been removed. The at, local_end_at and local_start_at methods should be used instead and the result (a TZInfo::TimestampWithOffset) converted to either a DateTime or Time by calling to_datetime or to_time on the result.

Misty De Méo · Answer 2 · Thu Jan 03 2019 14:18:06 GMT+0800 (China Standard Time)

I believe this is fixed by #204.

jprunel · Answer 3 · Fri Jan 04 2019 06:22:34 GMT+0800 (China Standard Time)

unsubscribe Jean-Baptiste Prunel +33 6 95 43 04 91 PGP (http://bit.ly/pgp-jbp) | Fingerprint : 60E0 4734 5235 A54B EC84 A386 F0C0 EDEA 3513 0113

…

On Jan 3 2019, at 7:18 am, Misty De Meo ***@***.***> wrote: I believe this is fixed by #204 (#204). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub (#203 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AWOrmsSvCspfbP_9CMdt30vc39mNd7hKks5u_aCfgaJpZM4ZnmmA).

Ryan Ahearn · Answer 4 · Tue Mar 05 2019 11:40:07 GMT+0800 (China Standard Time)

This should be fixed now. Releasing a new gem soon