text widgets overflowing from credit card in credit card page

Question

text widgets overflowing from credit card in credit card page

parth181195 opened this issue 6 years ago · comments

Parth Jansari commented 6 years ago

i will submit a pr for this issue

Pawan Kumar commented 6 years ago

Fixed

Parth Jansari · Answer 1 · Wed Sep 19 2018 11:08:55 GMT+0800 (China Standard Time)

it also causes the issue in landscape mode cause we are defining hight as 1/3 of the screen we should make it of a constant height

Pawan Kumar · Answer 2 · Wed Sep 19 2018 11:29:04 GMT+0800 (China Standard Time)

The app is not yet optimized for landscape mode and I opened this orientation just to see how many users actually use it. Regarding the overflow pixels, that needs to be fixed so I'll fix it in the next update.

…

On Wed 19 Sep, 2018, 8:38 AM Parth Jansari, ***@***.***> wrote: it also causes the issue in landscape mode cause we are defining hight as 1/3 of the screen we should make it of a constant height — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#15 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMCOnFPmDiIj5CUVRd7kfzAOUKcSVJCsks5ucbVKgaJpZM4WvVBx> .

Parth Jansari · Answer 3 · Wed Sep 19 2018 12:39:19 GMT+0800 (China Standard Time)

then should we use a fixed height for the card or increase the ratio from 0.3 to 0.4