Giters

iSoron / uhabits

Loop Habit Tracker, a mobile app for creating and maintaining long-term positive habits

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"Hide completed" should hide not daily habits when they are done during previous days

ettud opened this issue · comments

commented

uhabits/uhabits-core-legacy/src/main/common/org/isoron/uhabits/backend/MainScreenDataSource.kt

Line 58 in e4d2c93

if (!preferences.showCompleted) {

habit.type == HabitType.NUMERICAL_HABIT && checkmarks.getValue(habit)[0].value * 1000 < habit.target
Here only the current day is checked. However, imagine we have a weekly habit: a sum of the whole week should be checked. Same goes for boolean habits: if a mark was set during some time period (that should be calculated from frequency) a habit should be hidden. I also believe the app should check user culture to determine, which day is the first day of the week.

commented

Can you edit your title to better reflect what you mean?

I also believe the app should check user culture to determine, which day is the first day of the week.

That's a setting.

commented

Thank you for creating this issue, but we are closing it as it does not follow our bug report template. Please edit your issue to follow our bug report template and make sure to include all the required information (description of the problem, steps to reproduce and system information).