i-love-flamingo / flamingo-commerce

Flexible E-Commerce Framework on top of Flamingo. Used to build E-Commerce "Portals" and connect it with the help of individual Adapters to other services.

https://www.flamingo.me/flamingo-commerce.html

Behaviour of ProductCount() in cart.go should be unique

tlayh opened this issue 4 years ago · comments

Thomas Layh commented 4 years ago

Just wondering if the method ProductCount() has the correct behaviour. If there is the same product in two deliveries it will be counted twice. Shouldn't this function return the unique product count over all deliveries?

flamingo-commerce/cart/domain/cart/cart.go

Line 280 in 11a1fcd

func (c Cart) ProductCount() int {