hzoo / contributors-on-github

:cactus: Show stats about contributors on github

Home Page:https://chrome.google.com/webstore/detail/contributors-on-github/cjbacdldhllelehomkmlniifaojgaeph

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"Last update" is not showing date/time on hover of reload button

janpio opened this issue · comments

image

Looking into the sourcecode, it seems the necessary element is actually there, just not displayed:

image

Seems that the time element itself is not meant to output something by itself (any more?): https://developer.mozilla.org/en-US/docs/Web/HTML/Element/time

This should probably be updated to calculate the output in makeUpdateLabel itself then, from the time parameter (type Date) that method already gets.

The plot thickens: A bit of googling for "time relative-time" etc. leads to https://github.com/github/time-elements which is s custom thing from GitHub. Maybe they used to use time but now switched to something that doesn't mess with the standard html elements?

Indeed, replacing time here with relative-time (which I found via inspecting the "5 minutes ago" just in the comment above) fixes the problem.

PR incoming.