hzoo / contributors-on-github

:cactus: Show stats about contributors on github

Home Page:https://chrome.google.com/webstore/detail/contributors-on-github/cjbacdldhllelehomkmlniifaojgaeph

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Closing "Use OAuth" window outputs [object Object] in orange feedback bar below input

janpio opened this issue · comments

When you close the "Use OAuth" window with the "X" button (top right), this happens:

image

From look at the code, this seems to be setting this value:

}, (message) => {
document.querySelector("#feedback").textContent = message;
});

In Firefox this message indeed seems to be a simple string:

Error: "User cancelled or denied access."

But in Chrome it seems to be an object now:
image

Not sure how to properly fix this.

How about:

document.querySelector("#feedback").textContent = message.message
  ? `Error: ${message.message}`
  : message;
commented

Sounds good @mgol!