hypertrace / hypertrace-ui

UI for Hypertrace

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Trace drilldown to search (Trace)

jyothishjose6190 opened this issue · comments

From the trace waterfall graph, cliking on a trace should take me to the explore tab with the appropriate trace id

Could you a share screenshots where you'd envision clicking and the screen you'd want to see? At first I wasn't seeing any value here, but I'm guessing now you mean going from the trace waterfall to the span explorer (vs the default trace explorer), to allow filtering the spans from that trace? If that's the case, agree shouldn't be difficult to add.

@aaron-steinfeld clicking on trace id at the top of the waterfall graph should take us to the explore screen with trace id filter applied
Screenshot 2021-08-20 at 10 49 58 AM
Screenshot 2021-08-20 at 10 53 53 AM

got it, matches what I was thinking.

@aaron-steinfeld I would like to start working on this. How do you guys pass data between these pages, any standard practice you are following?

See ExploreFilterLinkComponent and ExplorerService.buildNavParamsWithFilters

Thanks, @jyothishjose6190 for picking this up!

In my opinion we can extend the same component to support that. Already we're using SummaryValueDisplayStyle input field to support style at least, now I think we may have a input field called Url (which could be optional), we can use the value of this to implement navigation.
cc: @aaron-steinfeld @anandtiwary

Just use something like this

            <ht-link
              [paramsOrUrl]="this.explorerNavParamsForSession$ | async"
              class="session-id-link"
            >
              <ht-summary-value></ht-summary-value>  // for trace id
            </ht-link>

Just use something like this

            <ht-link
              [paramsOrUrl]="this.explorerNavParamsForSession$ | async"
              class="session-id-link"
            >
              <ht-summary-value></ht-summary-value>  // for trace id
            </ht-link>

But due to this label will also be clickable. Do we want that?

Yeah that's fine. I think we are doing this at couple of places within Traceable

Closing this as this is done!!