update recommended fields
ansuz opened this issue · comments
should include "login" and "user".
"peerName" is apparently not super important.
user
is for server-side only -- used to identify user with a password, configurator.c seems optional
login
is matched against user
.. adds another barrier of cracking (notes way below)
peerName
is useful not required, but may be we can keep it required to keep peerStats populated?
So it's still an optional field, we'd need 9 of 35 nodes to update / commit their connection before tests pass.
./af/ng/lagos/akinbo.lagos.ng.k
./na/us/massachusetts/igel-massachusetts.usa.k
./na/us/newjersey/newark/h.transitiontech.ca.k
./na/us/california/igel-california.usa.k
./na/us/pennsylvania/nat.usa.k
./eu/nl/amsterdam/igel-amersfoort.ams.k
./eu/nl/amsterdam/weuxel.ams.k
./eu/nl/amsterdam/mrowr.me.k
./eu/fr/strasbourg/magik6k.net.k
If a "login" parameter is passed, someone sniffing on the wire can
sniff the packet and crack to find it. If the "login" is not passed
then the hash of the 'password' is effectively the login, therefore
that can be cracked.
I think login
is optional due to backwards compatibility (if I recall recorrectly).
Also, peerName
used to be optional, I made it required in #118 to ensure sane peerStats output.
+1 for whatever y'all think is best.
re: keep'em as required fields in test.py is fine.