hylo-lang / hylo

hylo/Sources/FrontEnd/Parse/Parser+Diagnostics.swift

Line 45 in 82808ee

    
           static func error(unterminatedCommentEndingAt endLocation: SourcePosition) -> Diagnostic {

Do we really ever want to report where an unterminated thing ends? Won't that always be the end of the file? Wouldn't it be more useful to point the user to where it began?

It looks like these failures mostly do get reported at the beginning and the labels/names are simply wrong.
The one exception that for some reason an unterminated outer comment gets reported at the beginning of the last terminated nested comment. The logic behind that is mysterious.

unterminated string/comment source locations seem a little strange