hxf31891 / react-gradient-color-picker

An easy to use color/gradient picker for React.js

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Option to disable dark mode

Rafi993 opened this issue · comments

commented

It should be possible to disable dark mode if needed (for apps that don't support dark mode)

@Rafi993 should be relatively easy to add. Will include in next update.

@Rafi993 not included in documentation yet but v3.0.5 adds disableDarkMode (bool) prop to picker.

Thanks for putting this together. I gave it a try today, but it doesn't seem to work. A quick search is showing only a single instance of disableDarkMode in the codebase, so maybe something went awry? 🤷

@hxf31891, am I reading this right, that the disableDarkMode prop was broken in commit 99ad3eb?

This is also preventing me to upgrade to v3, tried experimenting with Material-UI makeStyles overrides to no avail.

Made a draft PR that I haven't had time to test, hoping to do it by the end of the week.

Edit: Done, PR is ready for review.

@PierreAtUptale @TurekBot @Rafi993 this should be back as of 3.0.10