huynhsontung / Screenbox

LibVLC-based media player for the Universal Windows Platform

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Problem with selecting the playback speed

vladkryv opened this issue · comments

Describe the bug
Of the speeds offered, only 1x and 2x work, selecting other speeds does not change anything. At the same time everything works with “Custom value”.

How To Reproduce
Steps to reproduce the behavior:

  1. Open any video (I checked mp4)
  2. Click on 'Playback speed'
  3. Select 0.25/0.5/0.75/1.25/1.5/1.75 (any)
  4. See that the playback speed does not change

Expected behavior
Change the playback speed when choosing any option.

Environment

  • OS: Windows 11
  • Device: Asus Laptop (Intel Core i7-9750H; Intel UHD Graphics 630; NVIDIA GeForce GTX 1650)
  • App Version: v0.12.6.0

Additional context
Reproduce in Ukrainian and Russian interface language, in English there is no problem.

The problem is in this location -

if (!double.TryParse(speedText, out double speed)) return;

To solve the problem you can replace this line with
if (!double.TryParse(speedText, CultureInfo.InvariantCulture, out double speed))

In other places where the double.TryParse is used, I think you should also add this parameter.

Thank you for reporting. This issue has now been resolved in 5d08a92