Moving Currency and Pair to Types so all the types live under the same module
ainestal opened this issue · comments
I find it confusing when using the library that these 2 types are not in the types mod. It also forces the user to import other 2 mods instead of just types.
I also understand they are different from the rest of types implemented in the types mod.
So I'd like to ask you about moving them. What are your thoughts?
Yes I agree. Maybe we can make a "super" Types mod (folder) and put inside it Pair+Currency in one sub-mod, and the others types in an other one (no idea for the name yet)
I was thinking about just moving them into coinnect::types . I don't see the benefit for the user in having pair and currency in a specific mod.
Oh you mean in the same file, I see :) You can post a PR if you want or I will make one tomorrow
This is the PR #32
PR merged. I close