[Feature request] SpatialMaxPooling in ceil mode

Question

[Feature request] SpatialMaxPooling in ceil mode

szagoruyko opened this issue 9 years ago · comments

Caffe and Torch use different max pooling, caffe does ceil when computing output size and torch does floor. We have a switch in cudnn https://github.com/soumith/cudnn.torch/blob/master/Pooling.lua#L17, floor() and ceil() functions, and ceil max-pooling is here https://github.com/szagoruyko/imagine-nn/blob/master/SpatialMaxPooling.cu, clnn needs the same switch I think

Sergey Zagoruyko · Answer 1 · Fri Jul 17 2015 02:22:04 GMT+0800 (China Standard Time)

torch/cunn#106 has the new kernels with ceil, floor and padding support, I think kernels for clnn max pooling have to be taken from this PR.

Hugh Perkins · Answer 2 · Fri Jul 17 2015 06:55:09 GMT+0800 (China Standard Time)

Ok. Not sure if I have time for this in immediate future. Please consider submitting a PR for this.

Hugh Perkins · Answer 3 · Sat Jul 18 2015 17:46:07 GMT+0800 (China Standard Time)

Hi Sergey, please confirm whether you would like to implement this yourself, and use assignee to assign it to yourself, or whether you are hoping that I might implement it myself, and provide details on your expectations in terms of api and performance.

Sergey Zagoruyko · Answer 4 · Sat Jul 18 2015 20:20:13 GMT+0800 (China Standard Time)

Hi Hugh, this one is easy, you just copy kernels from the other PR, you can do it faster than me.

Hugh Perkins · Answer 5 · Tue Sep 22 2015 23:06:58 GMT+0800 (China Standard Time)

Hi Sergey, thanks. I will take a look :-)

Hugh Perkins · Answer 6 · Wed Sep 23 2015 13:02:29 GMT+0800 (China Standard Time)

Hi Sergey, merged across to clnn, in master branch. Please check.