pager schedule $SCHEDULE no longer returns anything

Question

pager schedule $SCHEDULE no longer returns anything

TheFynx opened this issue 9 years ago · comments

With 2.18, you can no longer return a specific schedule, merge 63 refactored most of this functionality, I think there's still a rogue reference to the oneScheduleMatching variable that was changed in the aforementioned merge.

Stephen Yeargin · Answer 1 · Tue Nov 17 2015 04:03:23 GMT+0800 (China Standard Time)

/cc @mmrobins

Aaron Blythe · Answer 2 · Tue Nov 17 2015 05:54:24 GMT+0800 (China Standard Time)

👍 Looks good.

Stephen Yeargin · Answer 3 · Tue Nov 17 2015 06:12:23 GMT+0800 (China Standard Time)

Fixed via #65

Matt Robinson · Answer 4 · Tue Nov 17 2015 07:07:27 GMT+0800 (China Standard Time)

was gonna look tonight, but glad @TheFynx got a fix in so quick, thx. It's hard to modify code without tests like this.

Levi Smith · Answer 5 · Tue Nov 17 2015 07:27:50 GMT+0800 (China Standard Time)

@mmrobins well, I may have not fixed it completely. I'll continue testing, but seems some of the stuff doesn't like hipchat. who's on call for has issues and it won't return schedule in hipchat (too many adapters...). I'll do some more testing and open up another issue.