No oncalls returns if `HUBOT_PAGERDUTY_SCHEDULES` is unset

[Russell Rollins]

I believe this issue was introduced in: #117

If the HUBOT_PAGERDUTY_SCHEDULES environment variable is unset, allowed_schedules is an empty array.

I think the intention of the line:

if !allowed_schedules or schedule.id in allowed_schedules

Is to allow all results if the environment variable is unset, however, the !allowed_schedules check is not truthy for empty arrays:

https://repl.it/repls/LoudLimpOolanguage

So instead, it allows no results.

I suspect a better check would be

if !allowed_schedules.length or schedule.id in allowed_schedules

[Stephen Yeargin]

My fault in the code review. 🐼 We were looking towards the completion of the new filters, but I forgot to guard backwards compatibility.

[Stephen Yeargin]

There's also another issue -- if a schedule doesn't have a person assigned to it, it will come through the list regardless.

[Russell Rollins]

@stephenyeargin no worries, caught the issue today when a hubot got automatically upgraded. I'm happy to open a PR to fix the first issue, but I'm not sure I fully understand the second.

[Stephen Yeargin]

Second issue isn't as critical since it's only showing up in the logs. My PR cleans up the logic a bit to avoid getting to that block.

[Stephen Yeargin]

Released in v3.1.1